It's only a subset of crates, but it's some of the most useful crates! Such a great feature ❤️

Thank you so much for your help on this! It's a tremendous improvement and I hope it inspires more people to contribute 🙏

So I started working on it in the evenings when I had time, and last week while I was off work for a week (recovering from eye surgery), in between naps I worked through most of the rule updates. So now almost all of them have documentation for their config options :)

github.com/oxc-project/...

Despite the warning, comments should be supported!
I believe they get stripped out so it doesn't affect the parsing, even if it's not named JSONC.

oxc.rs/docs/guide/u...

Thanks! Maybe I will give Go benchmarks another try. I have tried codspeed, but it only supports walltime benchmarks for now. Although the CPU simulation benchmarks are not accurate to the real-world, it has been useful for getting some consistent numbers. Have you used this successfully in CI?

If you'd like to reproduce these results:

Benchmark command: `hyperfine --ignore-failure --warmup 10 --runs 20 'pnpx [email protected] --silent' 'pnpx [email protected] --silent' 'pnpx [email protected] --silent' 'pnpx [email protected] --silent'`

elastic/kibana@2169baef
microsoft/vscode@fa994275

On the Kibana repository, oxlint 1.24 is 11% faster than v1.23, and up to 26% faster than v1.22 and below!

Benchmark command, if you'd like to reproduce this (microsoft/vscode@fa99427534301606eb84c30cd8f7701ac2c35f90):

hyperfine --ignore-failure --warmup 5 --runs 20 'pnpx [email protected] --silent' 'pnpx [email protected] --silent' 'pnpx [email protected] --silent' 'pnpx [email protected] --silent' 'pnpx [email protected] --silent'

must-use-promises? I feel like misused promises could be broken into separate rules like: no-unawaited-conditions, no-await-void-return, no-spread-promises. It's felt like 3 separate rules to me when reading the docs and configuring

Oh no, that sounds exhausting. Compared to C, I feel like my brain is already adapting to this style. Having all of the type declarations be extremely uniform is really nice for reducing cognitive load.

Heh, if I never have to apply the spiral rule ever again, it will be too soon.